Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for Testing Python container by container-ci-suite #675

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Apr 30, 2024

This pull request uses testing s2i-python-container in OpenShift 4 environment
by container-ci-suite.

@phracek phracek marked this pull request as draft April 30, 2024 12:35
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is just a draft so I did just a very quick review.

test/test_deploy_templates.py Outdated Show resolved Hide resolved
test/test_deploy_templates.py Outdated Show resolved Hide resolved
test/test_imagestreams_quickstart.py Outdated Show resolved Hide resolved
test/test_python_ex_template.py Show resolved Hide resolved
@phracek phracek force-pushed the use_container_ci_suite_for_openshift branch 5 times, most recently from 0be5b0a to b43002c Compare June 12, 2024 12:30
@phracek phracek marked this pull request as ready for review June 12, 2024 12:33
phracek added 2 commits June 13, 2024 10:58
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the use_container_ci_suite_for_openshift branch from 5ebdddb to 6131bb3 Compare June 13, 2024 08:59
@phracek
Copy link
Member Author

phracek commented Jun 13, 2024

[test-openshift-pytest]

Branch has to be master

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 13, 2024

After adding condition for Python-2.7 and RHEL7.

Running re-test again.

[test-openshift-pytest]

@phracek
Copy link
Member Author

phracek commented Jun 13, 2024

@frenzymadness It looks everything passed. Please take a look at it. Thanks.

Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found only a few possible improvements and you can freely ignore them if you want. It looks good and it works. Thank you.

test/test_deploy_templates.py Outdated Show resolved Hide resolved
test/test_latest_imagestreams.py Outdated Show resolved Hide resolved
test/test_python_ex_standalone.py Outdated Show resolved Hide resolved
phracek and others added 2 commits June 17, 2024 10:43
Co-authored-by: Lumír 'Frenzy' Balhar <lbalhar@redhat.com>
Co-authored-by: Lumír 'Frenzy' Balhar <lbalhar@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 17, 2024

[test-all]

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 17, 2024

Third-party libraries were separated from build-in

[test-all]

@phracek phracek merged commit b132443 into master Jun 18, 2024
33 checks passed
@phracek phracek deleted the use_container_ci_suite_for_openshift branch June 18, 2024 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants