-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for Testing Python container by container-ci-suite #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is just a draft so I did just a very quick review.
0be5b0a
to
b43002c
Compare
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
5ebdddb
to
6131bb3
Compare
[test-openshift-pytest] |
Branch has to be master Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
After adding condition for Python-2.7 and RHEL7. Running re-test again. [test-openshift-pytest] |
@frenzymadness It looks everything passed. Please take a look at it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found only a few possible improvements and you can freely ignore them if you want. It looks good and it works. Thank you.
Co-authored-by: Lumír 'Frenzy' Balhar <lbalhar@redhat.com>
Co-authored-by: Lumír 'Frenzy' Balhar <lbalhar@redhat.com>
[test-all] |
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Third-party libraries were separated from build-in [test-all] |
This pull request uses testing s2i-python-container in OpenShift 4 environment
by container-ci-suite.