Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redesign favorite repository layout #35

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Conversation

eheimbuch
Copy link

@eheimbuch eheimbuch commented Jul 23, 2021

Proposed changes

Redesign favorite repository layout to match new repository entry layout. Also use react-query for toggle favorite repository.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Jul 23, 2021
@eheimbuch eheimbuch force-pushed the feature/redesign_favorite_repo branch from 9c3e153 to a7a8dfd Compare July 23, 2021 11:05
@eheimbuch eheimbuch force-pushed the feature/redesign_favorite_repo branch from a7a8dfd to f409f4b Compare July 23, 2021 13:05
Copy link
Member

@sdorra sdorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landing page does not load.

image

Eduard Heimbuch and others added 2 commits July 28, 2021 13:22
Co-authored-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
@sdorra sdorra merged commit 1b9dcb4 into develop Jul 28, 2021
@sdorra sdorra deleted the feature/redesign_favorite_repo branch July 28, 2021 13:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants