Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Submit button for category selection #42

Merged
merged 5 commits into from
Nov 15, 2021

Conversation

pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Nov 12, 2021

Proposed changes

Changes to the displayed content has to be submitted explicitly.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@pfeuffer pfeuffer force-pushed the feature/submit_button_for_category_selection branch from 5318cc7 to b585a4d Compare November 12, 2021 14:54
@pfeuffer pfeuffer marked this pull request as ready for review November 12, 2021 15:04
@pfeuffer pfeuffer merged commit 5085751 into develop Nov 15, 2021
@pfeuffer pfeuffer deleted the feature/submit_button_for_category_selection branch November 15, 2021 15:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants