Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add handling for deleted repositories #65

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Conversation

Pilopa
Copy link
Contributor

@Pilopa Pilopa commented Jun 21, 2022

Proposed changes

When a repository is deleted, it should be displayed as an event in the activities tile. Also, when a repository is deleted/renamed, previous events regarding this repository should have their title text stroked through. This is achieved by manually going through all stored events and marking the relevant ones as "deleted".

Bulma's styling interacts unfavorably with the core change, which required linkless event tiles to be wrapped in a non-functional div to avoid mismatching visuals.

Requires scm-manager/scm-manager#2076

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@Pilopa Pilopa added the enhancement New feature or request label Jun 21, 2022
@Pilopa Pilopa marked this pull request as draft June 21, 2022 10:16
@Pilopa Pilopa marked this pull request as ready for review June 22, 2022 15:35
@eheimbuch eheimbuch merged commit 76ae636 into develop Jun 23, 2022
@eheimbuch eheimbuch deleted the feature/deleted_repos branch June 23, 2022 10:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants