Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/stub #1

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Feature/stub #1

merged 2 commits into from
Jun 23, 2020

Conversation

alextremp
Copy link
Member

Description

This PR adds the implementation for the TCF's v2 Stub

Additionally, it adds a pending command to the Stub in order to enable BorosTCF consuming the pending queue of accumulated calls.

Solves ticket/s

Review steps

  • can be started in local

npm run start

image

Memetized description

mandatory

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e411b87). Click here to learn what that means.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   76.81%           
=========================================
  Files             ?        9           
  Lines             ?       69           
  Branches          ?       11           
=========================================
  Hits              ?       53           
  Misses            ?        8           
  Partials          ?        8           
Impacted Files Coverage Δ
src/main/service/registerStub.js 60.00% <60.00%> (ø)
src/main/service/handler/PostMessageHandler.js 61.53% <61.53%> (ø)
src/main/service/waitUntil.js 63.63% <63.63%> (ø)
src/main/service/registerTcfApiLocator.js 81.81% <81.81%> (ø)
src/main/service/handler/TcfApiHandler.js 91.66% <91.66%> (ø)
src/main/index.js 100.00% <100.00%> (ø)
src/main/service/registerIframeMessageHandler.js 100.00% <100.00%> (ø)
src/main/service/registerTcfApiHandler.js 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e411b87...4606ab3. Read the comment docs.

@alextremp alextremp merged commit 9300042 into master Jun 23, 2020
@alextremp alextremp deleted the feature/stub branch June 23, 2020 07:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants