Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toByteBuffer
should only return a read-only buffer if necessary to protect its internals. Read-only buffers don't allow access to the underlying array which can force further copies downstream. If the data is already being copied, then there is no reason to return a read-only buffer.Add
toByteBufferUnsafe
. In the spirit oftoArrayUnsafe
, but can avoid copies in several more situations e.g. a view of a slice of an array. This will enable copy-free transforms toChunk.ArraySlice
in FS2.