Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mark which version something was deprecated in #893

Closed
4 tasks
scop opened this issue Feb 25, 2023 · 1 comment · Fixed by #975
Closed
4 tasks

Mark which version something was deprecated in #893

scop opened this issue Feb 25, 2023 · 1 comment · Fixed by #975

Comments

@scop
Copy link
Owner

scop commented Feb 25, 2023

Describe the feature/solution

  • note "deprecated in" bash-completion version in @deprecated comments
  • add new parameter to _comp_deprecate_func to specify the "deprecated in" bash-completion version (could use this in warning messages if we ever start to emit them)

Originally from #870.

Maintenance (please complete the following information)

  • This is a request for new completion
  • Link to upstream project query about shipping the completion:
@scop scop mentioned this issue Feb 25, 2023
Merged
4 tasks
@scop scop mentioned this issue May 7, 2023
Closed
@scop
Copy link
Owner Author

scop commented May 7, 2023

Deprecation comment could be like @deprecated VERSION commentary here. I made #961 do that.

scop added a commit that referenced this issue May 9, 2023
@scop
docs(api-and-naming): note @since and @deprecated versioning
2fcfdf8 
- #893
- #963
scop added a commit that referenced this issue May 9, 2023
@scop
refactor(_comp_deprecate_func): add version parameter
5de5e74 
Making it the first one to make forgetting or faking it harder.

#893
@scop scop mentioned this issue May 9, 2023
Merged
scop added a commit that referenced this issue May 9, 2023
@scop
refactor(_comp_deprecate_func): add version parameter
7798441 
Making it the first one to make forgetting or faking it harder.

#893
scop added a commit that referenced this issue May 9, 2023
@scop
docs(api-and-naming): note @since and @deprecated versioning
00194dc 
- #893
- #963
scop added a commit that referenced this issue May 9, 2023
@scop
refactor(_comp_deprecate_func): add version parameter
9b70abe 
Making it the first one to make forgetting or faking it harder.

#893
@scop scop closed this as completed in #975 May 9, 2023
scop added a commit that referenced this issue May 9, 2023
@scop
Merge pull request #975 from scop/docs/since-deprecated-versions
8b1356a 
chore: since/deprecation versioning 

Closes #893
Closes #963
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: since/deprecation versioning scop/bash-completion
1 participant
@scop