feat(*sum): handle more common checksum filenames #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checksums, checksums.txt, ${sumtype}sums, ${sumtype}sums.txt
akinomyoga
reviewed
Mar 12, 2025
| for opt in "${words[@]}"; do | ||
| if [[ $opt == -@(c|-check) ]]; then | ||
| _comp_compgen_filedir "$sumtype" | ||
| _comp_compgen -v files filedir && | ||
| _comp_compgen -- -X "!$sumglob" -W '"${files[@]}"' |
There was a problem hiding this comment.
This filters out directory names generated by _comp_compgen_filedir, but we might want to generate also directory names.
There was a problem hiding this comment.
Ah, true, drafting until fixed.
There was a problem hiding this comment.
As I mentioned in #1358 (comment) a bit, I'm currently thinking of extending _comp_compgen_filedir to accept options to specify the whole glob pattern (instead of just the filename-extension part).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checksums, checksums.txt, ${sumtype}sums, ${sumtype}sums.txt