Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

new file #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

new file #1

wants to merge 1 commit into from

Conversation

scottsand-db
Copy link
Owner

No description provided.

scottsand-db added a commit that referenced this pull request Nov 1, 2024
#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [X] Kernel
- [ ] Other (fill in here)

## Description

- adds a new `TableIdentifier` class, that kernel will pass on to Commit
Coordinator Client
- adds a new `Table::forPathWithTableId(engine, path, tableId)`
interface
- the tableId is stored as an `Optional` in the `Table`, and this PR
does **not** propagate that value into SnapshotManager, Snapshot, etc.
Future PRs can take care of that.

## How was this patch tested?

TableIdentifier UTs

## Does this PR introduce _any_ user-facing changes?

Yes. See the above.
scottsand-db added a commit that referenced this pull request Nov 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…#3795)"

This reverts commit 024dadb.
scottsand-db added a commit that referenced this pull request Dec 3, 2024
scottsand-db added a commit that referenced this pull request Dec 4, 2024
…#3795)" (delta-io#3900)

This reverts commit 024dadb.

We seem to be rethinking our Coordinated Commits CUJ / APIs, and we
don't want these APIs leaked in Delta 3.3.
scottsand-db pushed a commit that referenced this pull request Mar 31, 2025
…4316)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [x] Kernel
- [ ] Other (fill in here)

## Description

<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->

Split the main PR delta-io#4265 for faster
review

Adds the writer table feature clustering.

## How was this patch tested?

<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->

Updates unit tests. E2E testing would be added later once table creation
with this table feature supported.



## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant