Update to "Handle promise rejection for sound.play() in preload" #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2019 08:32
|
Should we make a PR for a similar change into blockly to resolve the issues created by google/blockly#2162? |
|
@epicfaace I think that would be a good idea, I can see that a similar change has already been proposed in the PR you linked. |
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my colleague Michael is on vacation, I added the requested changes to his pull request.
Resolves
audio play() called before user interaction Blockly fix
Proposed Changes
Handle promise rejection for sound.play() in preload.
Reason for Changes
This removes the error, "play() failed because the user didn't interact with the document first."
This is good in itself, but that exception turned out to be the reason for a several seconds delay after the first interaction on iOS.
Test Coverage
None