Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: [UEPR-165] Merged native branch in scratch gui #216

Open
wants to merge 103 commits into
base: develop
Choose a base branch
from

Conversation

Bogomil-Stoyanov
Copy link

@Bogomil-Stoyanov Bogomil-Stoyanov commented Mar 13, 2025

Ticket:
UEPR-165

Changes: Merged develop into native branch

paulkaplan and others added 30 commits April 19, 2019 12:56
Use the same implementation as onSetProjectThumbnailer which does the same thing for getting a thumbnail externally.
Usually we generate a thumbnail when a project is changed. If a project is imported on Android it doesn’t have a thumbnail, and if you just run it without changes it still doesn’t have a thumbnail.

Adding `saveThumbnailOnLoad` flag that Android sets if the project doesn’t have a thumbnail.
Generate a thumbnail for new projects and imported projects when loaded on android
* use `isShowingWithId` instead of `isLoading`, loading finishes while project id is still `“0”` for new projects
* use a timeout for storing the project thumbnail to ensure that it happens after target skins are rendered (they are rendered async)
cwillisf and others added 28 commits March 3, 2022 09:39
chore: update native branch with monorepo-integration branch
chore: update native branch with develop branch
…h-android

Monorepo Scratch android branch
@Bogomil-Stoyanov Bogomil-Stoyanov requested a review from a team as a code owner March 13, 2025 10:52
Copy link

github-actions bot commented Mar 13, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


3 out of 8 committers have signed the CLA.
✅ (cwillisf)[https://github.com/cwillisf]
✅ (MiroslavDionisiev)[https://github.com/MiroslavDionisiev]
✅ (Bogomil-Stoyanov)[https://github.com/Bogomil-Stoyanov]
@paulkaplan
@chrisgarrity
@dd Liu
@fsih
@andy O'Neill
DD Liu, Andy O'Neill seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants