Remove svg: tag prefix in fixupSvgString
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
remove-tags-svg-prefix
branch
from
f8bfb45 to
e524fa4
Compare
10 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-paint#1320
Closes #197
Proposed Changes
This PR adds functionality to
fixupSvgStringto remove thesvg:prefix from all tags that may have it.Reason for Changes
Both DOMPurify and the paint editor seem to choke on prefixed tags, which Inkscape will sometimes output (see #197 for more on DOMPurify). This allows SVGs with prefixed tags to load properly once more.
I was a bit wary of going the regex route, but this method already uses copious amounts of parsing-XML-with-regex, so surely one more can't hurt.
Test Coverage
A test has been added to ensure this works