feat: a non-working attempt to add automerge-repo to scratch-vm #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very start of a rough draft of a patch to integrate automerge into Scratch.
The approximate strategy is to create an automerge document for each Sprite (and its blocks) and then a parent document for the Project.
Right now, this patch doesn't even build because webpack is complaining about our dialect of Javascript which takes advantage of features like private properties.
I tested this by linking this scratch-vm into a local scratch-gui instance. Would love help figuring out how get it building, even if the report is just "works on my machine!"
cc/ @alexjg who might also have ideas about webpack and automerge