fix: Correcting Case Sensitivity #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally exposing error to CLI output and fixing tests
stjohnjohnson
force-pushed
the
case-sensitive
branch
from
5986a5d to
f4eff46
Compare
|
No new test? |
|
Actually. The previous tests checked for this case. But we didn’t check the
output of the tests. :)
…On Wed, Sep 26, 2018 at 17:56 Tiffany K ***@***.***> wrote:
No new test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl98UPjgghqN2FLtZIFUbCtUqX7tIMFks5ufCI-gaJpZM4W7qiZ>
.
|
tkyi
approved these changes
Sep 27, 2018
d2lam
approved these changes
Sep 27, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If your git log message contains non-lowercase field types (e.g.
[MAJOR] Something), thengitversion bump autowould exit unsuccessfully with no error message.Objective
Support a user writing
major,minor, andpatchin their commit message regardless of case.