Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: TerminateSleep argument order #448

Merged
merged 5 commits into from
Nov 29, 2022

Conversation

y-oksaku
Copy link
Contributor

Context

Test TestUpdateBuildNonZeroFailure failed, but the build does not failed.

https://cd.screwdriver.cd/pipelines/21/builds/832517

Objective

This PR corrects the argument order.

func TerminateSleep(shellBin, sourceDir string, killAll bool) {

References

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@y-oksaku
Copy link
Contributor Author

y-oksaku commented Nov 21, 2022

TerminateSleep is now called in launcher_test.go, so it looks like the sleep command in test has been killed and the test is failing.

https://cd.screwdriver.cd/pipelines/21/builds/833232/steps/test

@y-oksaku y-oksaku marked this pull request as ready for review November 24, 2022 02:30
@tkyi tkyi closed this Nov 29, 2022
@tkyi tkyi reopened this Nov 29, 2022
@tkyi tkyi merged commit e1fb5bc into screwdriver-cd:master Nov 29, 2022
@y-oksaku y-oksaku deleted the y-okesak-patch-1 branch December 6, 2022 00:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants