Skip to content

fix: only enforce minimum version constraint, not maximum #55

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jim80net opened this issue May 31, 2023 · 1 comment · Fixed by #58
Closed

fix: only enforce minimum version constraint, not maximum #55

jim80net opened this issue May 31, 2023 · 1 comment · Fixed by #58
Labels
released

Comments

@jim80net
Copy link
Contributor

Hey @jim80net, it's pretty uncommon for modules to specify a cap on the required Terraform version, normally they only enforce a minimum. (Any of the aws managed Terraform modules should serve as an example)

Specifying a cap blocks users from upgrading to newer versions and requires that these small PRs are opened and reviewed every time a new version of Terraform is released. Would you guys consider only enforcing a minimum?

Thanks to @dtw45 for the suggestion.
frozenSolid added a commit to frozenSolid/terraform-aws-datadog that referenced this issue Aug 16, 2023
@frozenSolid
fixes scribd#55
08ed470 
fixes scribd#55
@frozenSolid frozenSolid mentioned this issue Aug 16, 2023
Merged
jim80net pushed a commit that referenced this issue Aug 16, 2023
@frozenSolid
fix: enforce only minimum version of terraform
7195f64 
fixes #55
github-actions bot pushed a commit that referenced this issue Aug 16, 2023
@semantic-release-bot
chore(release): 3.2.2 [skip ci]
3ca76a2 
## [3.2.2](v3.2.1...v3.2.2) (2023-08-16)

### Bug Fixes

* enforce only minimum version of terraform ([7195f64](7195f64)), closes [#55](#55)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #55 frozenSolid/terraform-aws-datadog
1 participant
@jim80net