Skip to content

feat!:BREAKING CHANGE:enable support for aws provider 4.0+ #48

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 6 commits into from

Conversation

kuntalkumarbasu
Copy link
Contributor

@kuntalkumarbasu kuntalkumarbasu commented Mar 12, 2022

This should fix #43
BREAKING CHANGE
Based on the below understanding , I think we do not need to do manual import in most of the cases. However we should create a major version though.

Each of the new aws_s3_bucket_* resources relies on S3 API calls that utilize a PUT action in order to modify the target S3 bucket. Because these API calls adhere to standard HTTP methods for REST APIs, they should handle situations where the target configuration already exists (as noted in the HTTP RFC). Given that this is the case, it's not strictly necessary to import any new aws_s3_bucket_* resources that are a one-to-one translation from previous versions of the AWS provider -- on the next terraform apply, they'll attempt the PUT, and update the state with the results as necessary. There is, however, a downside to this approach in that the diff will show each of the new resources as needing to be created.

@kuntalkumarbasu kuntalkumarbasu self-assigned this Mar 12, 2022
Copy link
Contributor

@jim80net jim80net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuntalkumarbasu, would you please include a new change to the README that comments on the breaking change in https://github.com/scribd/terraform-aws-datadog/blob/master/README.md#module-versions?

Also, would you please either:

  • include a bang character for the commit message (feat!: enable support for aws provider 4.0)
  • include the string BREAKING CHANGE in the commit body.

Thanks!

@kuntalkumarbasu kuntalkumarbasu changed the title feat:enable support for aws provider 4.0+ feat!:BREAKING CHANGE:enable support for aws provider 4.0+ Mar 14, 2022
@kuntalkumarbasu kuntalkumarbasu deleted the upgrade-aws-prov branch March 16, 2022 21:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor aws s3 bucket to be compatible with Aws provider 4.0
3 participants