Fix statement_id length
#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim80net
reviewed
May 24, 2023
Co-authored-by: Jim Park <jimp@scribd.com>
jim80net
approved these changes
Jul 11, 2023
|
Thanks for the contribution @jjkoh95! |
jim80net
added a commit
that referenced
this pull request
Jul 20, 2023
* Fix `statement_id` length * Update logs_monitoring_cloudwatch_log.tf Co-authored-by: Jim Park <jimp@scribd.com> --------- Co-authored-by: Jim Park <jimp@scribd.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
## [3.2.1](v3.2.0...v3.2.1) (2023-07-20) ### Bug Fixes * Truncate `statement_id` length after 100 characters ([#54](#54)) ([3f98ed3](3f98ed3))
|
I rebased the last commit since the commit wasn't formatted correctly for the release process. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While typical statement_id is generated by terraform -- https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_permission.html
if log-groups are too lengthy, this will cause issue where
statement_idis more than 100 characters, refer - https://docs.aws.amazon.com/lambda/latest/dg/API_AddPermission.html#API_AddPermission_RequestSyntax