Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: skip ccc.ErrUnknown txns immediately #1027

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Sep 6, 2024

1. Purpose or design rationale of this PR

otherwise they might keep triggering reorgs until they happen to be the txn at index 0

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Sep 6, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@omerfirmak
Copy link
Author

nice catch.

props to @Thegaram for raising this

@omerfirmak omerfirmak merged commit a4b738f into develop Sep 6, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/skip-err-unknown branch September 6, 2024 13:12
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants