Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(libzkp): upgrade to use prover v0.9.0 #513

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Sep 14, 2023

1. Purpose or design rationale of this PR

Upgrade to depend on zkevm-circuits/prover v0.9.0.
Could reference this notion for details.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@silathdiir silathdiir changed the title [WIP] fix(libzkp): upgrade to use prover v0.9.0 fix(libzkp): upgrade to use prover v0.9.0 Sep 14, 2023
0xmountaintop
0xmountaintop previously approved these changes Sep 14, 2023
georgehao
georgehao previously approved these changes Sep 14, 2023
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle Error::InternalError("check rw failed") anywhere in the go code?

@0xmountaintop
Copy link

Do we need to handle Error::InternalError("check rw failed") anywhere in the go code?

OK I will handle in this PR

@0xmountaintop 0xmountaintop marked this pull request as draft September 14, 2023 08:14
@0xmountaintop 0xmountaintop marked this pull request as ready for review September 14, 2023 09:30
* improve

* minor

* minor
@0xmountaintop 0xmountaintop dismissed stale reviews from georgehao and themself via e9d25f0 September 14, 2023 09:56
@0xmountaintop
Copy link

Do we need to handle Error::InternalError("check rw failed") anywhere in the go code?

Seems needing some efforts to handle it.

I think we can just print the error and let it be caught by grafana

@0xmountaintop 0xmountaintop merged commit 2b22bf9 into develop Sep 14, 2023
@0xmountaintop 0xmountaintop deleted the libzkp-v0.9.0 branch September 14, 2023 11:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants