Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(txpool): revert duplicated l1 data fee check #612

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jan 1, 2024

1. Purpose or design rationale of this PR

  1. Revert duplicated l1 data fee check in: fix(tx-pool): consider L1 data fee in validateTx #609
  2. Move gas fee check after other basic checks, because gas fee check needs state access.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo added bug Something isn't working bump-version labels Jan 1, 2024
@colinlyguo colinlyguo self-assigned this Jan 1, 2024
@colinlyguo colinlyguo force-pushed the revert-duplicated-l1-data-fee-check branch from 0d3fee1 to fd83e14 Compare January 1, 2024 13:57
@Thegaram Thegaram changed the title fix(to-pool): revert duplicated l1 data fee check fix(txpool): revert duplicated l1 data fee check Jan 2, 2024
@colinlyguo colinlyguo requested a review from Thegaram January 2, 2024 15:56
@0xmountaintop 0xmountaintop merged commit 219b84e into develop Jan 8, 2024
5 checks passed
@0xmountaintop 0xmountaintop deleted the revert-duplicated-l1-data-fee-check branch January 8, 2024 12:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working bump-version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants