Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(zktrie): fix NewZktrieDatabase #638

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

0xmountaintop
Copy link

@0xmountaintop 0xmountaintop commented Feb 21, 2024

1. Purpose or design rationale of this PR

minor fix. though won't affect our normal path.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title feat(zktrie): fix NewZktrieDatabase fix(zktrie): fix NewZktrieDatabase Feb 21, 2024
noel2004
noel2004 previously approved these changes Mar 6, 2024
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixing is correct. Thank you

@0xmountaintop 0xmountaintop merged commit 3cf590b into develop Mar 27, 2024
6 checks passed
@0xmountaintop 0xmountaintop deleted the fix_NewZktrieDatabase branch March 27, 2024 06:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants