Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(state): fix iterativeDump.OnAccount #649

Merged
merged 5 commits into from
Apr 5, 2024
Merged

fix(state): fix iterativeDump.OnAccount #649

merged 5 commits into from
Apr 5, 2024

Conversation

0xmountaintop
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title fix iterativeDump.OnAccount fix(state): fix iterativeDump.OnAccount Mar 2, 2024
georgehao
georgehao previously approved these changes Apr 3, 2024
@georgehao
Copy link
Member

what's the purpose of add this field?

@0xmountaintop
Copy link
Author

0xmountaintop commented Apr 4, 2024

what's the purpose of add this field?

because it's missing and we should add it

roylou
roylou previously approved these changes Apr 4, 2024
@github-actions github-actions bot dismissed stale reviews from georgehao and roylou via 6781f1a April 4, 2024 10:53
@0xmountaintop 0xmountaintop merged commit 0bccb7b into develop Apr 5, 2024
@0xmountaintop 0xmountaintop deleted the fix_dump branch April 5, 2024 03:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants