fix(zktrie): copy trie properly for concurrent access #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
omerfirmak/flakey-zktrie-test
branch
from
9eae752 to
cb35e59
Compare
omerfirmak
changed the title
colinlyguo
previously approved these changes
May 13, 2024
colinlyguo
reviewed
May 13, 2024
New ZkTrie has some internal fields that need to be deep copied. Simply dereferencing the pointer to the trie only creates a shallow copy. |
0xmountaintop
previously approved these changes
May 13, 2024
github-actions
bot
dismissed stale reviews from 0xmountaintop and colinlyguo
via
989ca7b
0xmountaintop
approved these changes
May 13, 2024
Thegaram
approved these changes
May 13, 2024
colinlyguo
approved these changes
May 13, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jun 5, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jun 11, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jun 11, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jun 13, 2024
0xmountaintop
added a commit
that referenced
this pull request
Jun 13, 2024
* feat(zktrie): bump to `v0.8.4` * fix(zktrie): copy trie properly for concurrent access (#747) * fix `ZkTrie` `Commit` * some fixes --------- Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
as reported by @colinlyguo here
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?