Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(zktrie): remove an outdated comment #765

Merged
merged 2 commits into from
May 23, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented May 22, 2024

1. Purpose or design rationale of this PR

removing an outdated comment for clarity, zktrie now uses lazy committment, so commit actually will write db. no need to bump the version.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • docs: Documentation-only changes

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo requested a review from omerfirmak May 22, 2024 14:13
@Thegaram Thegaram merged commit e5b4f3e into develop May 23, 2024
7 checks passed
@Thegaram Thegaram deleted the fix-zktrie-remove-an-outdated-comment branch May 23, 2024 13:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants