Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Support arm64 dedicated workflow #840

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

sbaizet-ledger
Copy link
Member

@sbaizet-ledger sbaizet-ledger commented Jun 20, 2024

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@sbaizet-ledger sbaizet-ledger changed the title Support arm64 dedicated workflow ci: Support arm64 dedicated workflow Jun 20, 2024
@sbaizet-ledger sbaizet-ledger merged commit f2efa44 into develop Jun 20, 2024
8 checks passed
@sbaizet-ledger sbaizet-ledger deleted the support-arm64-dedicated-workflow branch June 20, 2024 09:07
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Jun 25, 2024
* add self hosted runner to publish arm64 images

* test build with macos and ubuntu arm64

* Add docker to mac runner and remove qemu

* dedicated workflow for arm64 image

* cleaning
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants