Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: rename CCC package for less repetition #967

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Aug 7, 2024

1. Purpose or design rationale of this PR

circuitcapacitychecker.CircuitCapacityChecker was bothering me for so long.

also removes legacy worker

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak force-pushed the omerfirmak/async-ccc branch from 957dd49 to 4a7f46e Compare August 8, 2024 12:28
@omerfirmak omerfirmak force-pushed the omerfirmak/async-ccc branch from 4a7f46e to a9d0822 Compare August 8, 2024 14:54
@omerfirmak omerfirmak changed the title feat: async ccc checker refactor: rename CCC package for less repetition Aug 8, 2024
@omerfirmak omerfirmak merged commit 2411ae0 into develop Aug 9, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/async-ccc branch August 9, 2024 05:21
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants