Skip to content

adapt for "upgrade 5 refactor" #351

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Nov 8, 2024
Merged

adapt for "upgrade 5 refactor" #351

merged 9 commits into from
Nov 8, 2024

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Nov 7, 2024

TODO:
need some small change, so batch prover can load chunk_halo2.protocol and chunk_sp1.protocol
need to manually copy vk_batch_agg.vkey

the save/load must be broken. After it generated batch proof (but panics due to lack of "vk_batch_agg.vkey"), i rebooted it with OUTPUT_DIR=XXX, but it is proving chunk again.. chunk proof loading must be broken.

need to adjust batch circuit size:

index be4fea7..6b6b86a 100644
--- a/integration/configs/layer3.config
+++ b/integration/configs/layer3.config
@@ -2,7 +2,7 @@
   "strategy": "Simple",
   "degree": 21,
   "num_advice": [
-    63
+    85
   ],
   "num_lookup_advice": [
     8

@lispc
Copy link
Collaborator Author

lispc commented Nov 7, 2024

panic in last step

can be reproduced bash e2e.sh. panic after ~5min

2024-11-07T12:33:31.001545284+00:00 DEBUG prover::utils - read env var SCROLL_PROVER_DUMP_YUL, result: true
thread 'test_e2e_prove_verify' panicked at integration/src/prove.rs:95:10:
called `Result::unwrap()` on an `Err` value: Serde(Error("can only flatten structs and maps (got unit struct)", line: 0, column: 0))
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: integration::prove::prove_and_verify_bundle
   4: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
test test_e2e_prove_verify ... FAILED

@roynalnaruto roynalnaruto self-requested a review November 7, 2024 17:47
@lispc lispc changed the title testing "upgrade 5 refactor" adapt for "upgrade 5 refactor" Nov 8, 2024
@lispc lispc merged commit 66b0aee into main Nov 8, 2024
5 checks passed
@lispc lispc deleted the chore/upgrade-5 branch November 8, 2024 06:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants