Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert package names #10

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Revert package names #10

merged 6 commits into from
Feb 22, 2023

Conversation

toml01
Copy link
Member

@toml01 toml01 commented Feb 22, 2023

The chosen path is to change the names of our versions of cosmwasm std packages to cosmwasm-* (i.e. to be the same as vanilla).

Reasoning:

Seems like keeping the package name as secret-cosmwasm-* prevents us from using any libraries that are intended for the vanilla cosmwasm.

The reason is that you can't patch a crate with a differently named crate.

For example:

cw-storage-plus internally uses cosmwasm-storage as a dependency. We would want to patch that, but since our crate is called secret-cosmwasm-storage, the patch would not apply here.

Related source: rust-lang/cargo#9227

On the other hand, having our packages named cosmwasm-* allows the above and does not prevent us from doing things like crosschain-single-codebase-contracts (meaning using both vanilla and secret versions as dependencies of the same crate) - you would just need to separate them with features.

The downside is that we will not be able to publish our version to crates.io, meaning that importing this crate will look like this:

cosmwasm-std = { git = "https://github.com/scrtlabs/cosmwasm", tag = "v1.1.0" }

# Instead of:

cosmwasm-std = { package = "secret-cosmwasm-std", version = "1.1" }

(this is just a semantic difference - no difference in functionality)

@toml01 toml01 force-pushed the revert-package-names branch from 8c47b15 to 9d4842f Compare February 22, 2023 15:39
@toml01 toml01 merged commit 310f940 into secret-cw1.1 Feb 22, 2023
@toml01 toml01 deleted the revert-package-names branch February 22, 2023 15:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants