Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chosen path is to change the names of our versions of cosmwasm std packages to
cosmwasm-*
(i.e. to be the same as vanilla).Reasoning:
Seems like keeping the package name as
secret-cosmwasm-*
prevents us from using any libraries that are intended for the vanilla cosmwasm.The reason is that you can't patch a crate with a differently named crate.
For example:
cw-storage-plus
internally usescosmwasm-storage
as a dependency. We would want to patch that, but since our crate is calledsecret-cosmwasm-storage
, the patch would not apply here.Related source: rust-lang/cargo#9227
On the other hand, having our packages named
cosmwasm-*
allows the above and does not prevent us from doing things like crosschain-single-codebase-contracts (meaning using both vanilla and secret versions as dependencies of the same crate) - you would just need to separate them with features.The downside is that we will not be able to publish our version to crates.io, meaning that importing this crate will look like this:
(this is just a semantic difference - no difference in functionality)