Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: upgrade to angular 17 #1008

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: upgrade to angular 17 #1008

merged 2 commits into from
Nov 16, 2023

Conversation

scttcper
Copy link
Owner

BREAKING CHANGE: requires angular 17, typescript 5.2

BREAKING CHANGE: requires angular 17, typescript 5.2
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e3e4b74) 55.57% compared to head (26523b0) 54.76%.

Files Patch % Lines
src/lib/toastr/toast-noanimation.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   55.57%   54.76%   -0.82%     
==========================================
  Files          20       20              
  Lines         511      504       -7     
  Branches       89       89              
==========================================
- Hits          284      276       -8     
+ Misses        217      216       -1     
- Partials       10       12       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scttcper scttcper merged commit d6b5e6b into master Nov 16, 2023
2 checks passed
@scttcper scttcper deleted the ng17 branch November 16, 2023 04:20
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Dixyx pushed a commit to Dixyx/ngx-toastr that referenced this pull request Nov 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant