Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove path from command. #86

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Remove path from command. #86

merged 1 commit into from
Feb 15, 2021

Conversation

kicken
Copy link
Contributor

@kicken kicken commented Feb 15, 2021

Including the ./vendor/bin path in the sculpin-watch command prevents the command from being run successfully on windows.

w:\sculpin>composer sculpin-watch
> Composer\Config::disableProcessTimeout
> ./vendor/bin/sculpin generate --watch --server
'.' is not recognized as an internal or external command,
operable program or batch file.
Script ./vendor/bin/sculpin generate --watch --server handling the sculpin-watch event returned with error code 1

The path is not necessary as composer adds the bin directory to PATH before running commands.

Removing the path from the command definition then resolves the issue and allows the command to be run successfully on windows.

W:\sculpin>composer sculpin-watch
> Composer\Config::disableProcessTimeout
> sculpin generate --watch --server
Detected new or updated files
Generating: 100% (43 sources / 0.00 seconds)
Converting: 100% (73 sources / 0.47 seconds)
Formatting: 100% (73 sources / 0.04 seconds)
Processing completed in 0.72 seconds
Starting Sculpin server for the dev environment with debug true
Development server is running at http://localhost:8000
Quit the server with CONTROL-C.

@beryllium
Copy link
Member

Well that's quite a TIL (today-I-learned). Thanks for finding that out & fixing it!

@beryllium beryllium merged commit 82af7f1 into sculpin:master Feb 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants