Restore cells_as_circles default to True and add deprecation warning.
#184
Comments
|
Sounds like a good task to experiment with GitHub Workspace, the new AI tool form GitHub @Zethson. |
LucaMarconato
added a commit
that referenced
this issue
Aug 1, 2024
This PR is AI generated (Copilot Workspace). Related to #184 Revert the default value of `cells_as_circles` to `True` and add a deprecation warning. * Change the default value of the `cells_as_circles` parameter to `None` in the `xenium` function. * Add a deprecation warning indicating that the default will change to `False` in the next release. * Add logic to set `cells_as_circles` to `True` if it is `None` and display the deprecation warning. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/scverse/spatialdata-io/issues/184?shareId=XXXX-XXXX-XXXX-XXXX).
lucas-diedrich
pushed a commit
to lucas-diedrich/spatialdata-io
that referenced
this issue
Nov 26, 2024
This PR is AI generated (Copilot Workspace). Related to scverse#184 Revert the default value of `cells_as_circles` to `True` and add a deprecation warning. * Change the default value of the `cells_as_circles` parameter to `None` in the `xenium` function. * Add a deprecation warning indicating that the default will change to `False` in the next release. * Add logic to set `cells_as_circles` to `True` if it is `None` and display the deprecation warning. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/scverse/spatialdata-io/issues/184?shareId=XXXX-XXXX-XXXX-XXXX).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The PR #179 fixes a problem of radii being nan for Xenium 2.0.0 data #173, and also changes the default value for
cells_as_circlesfromTruetoFalse.Before release we should:
TrueTrueexplicitly to maintain the current behavior"The text was updated successfully, but these errors were encountered: