-
Notifications
You must be signed in to change notification settings - Fork 33
add steinbock #13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add steinbock #13
Conversation
Hi @giovp, thanks so much for working on this! A couple of comments from my side:
Taken together, I see two options on how to deal with this flexibility (these are not mutually exclusive!):
No, I think images, labels (masks), tabular data (intensities, regionprops) and neighbors should suffice.
This data is extracted from MCD raw data during conversion to TIFF using readimc, see here. However, please bear in mind that such a file will only be generated when working with IMC raw data. For other multiplexed imaging technologies, where users directly start from TIFF, this information will not be available out of the box. But yes, one could recover the instrument's coordinate space using this information, as done e.g. by the napari-hierarchical plugin. |
hi @jwindhager , thanks a lot for prompt reply.
understand this, yet for making use of the data in spatialdata at all at least region and tables should be specified. Do you think it'd be fine to make those as required and the rest optional?
got it, would you suggest than that the user could also supply absolute paths instead of just the "dataset_id" ?
makes sense thanks, I believe this is what it is done also now (reading a single h5ad)
so motivation for hardcoding file names was reducing verbosity. From taking a look at the example directory, it seemed like the "dataset_id" was the experimental key used across files. I could see the option though to pass explicit paths (at least to the image, segmentation and table folders) as well.
thanks this is very useful, will take a look. |
merged in #19 |
think we'll have to revisit anyway once user start using it |
Seems like I am one of the first to test it in the wild. As @jwindhager explained, steinbock offers a flexible way of working with your steinbock working directory. I tried using |
Thank you @LukasHats for reporting on this and for the explanation. Would you be up for making a small PR to address these issues? |
@LucaMarconato Happy to do so once I make the reader work! |
To test this out is a bit convoluted, but basically:
io/updates
download.py
insteinbock
folder.shapesmodel/id
io/steinbock
This is how it looks:

pinging @jwindhager and @nilseling in case you could provide any feedback, would be much appreciated.
Right now I'm importing:
you guys did a fantastic work with providing in the
h5ad
all the info also presents in the rest of thecsv
files. Am I missing anything particularly important that you think it should be included in the in-memory object?on a separate note: I noticed that there are also coordinates such as
Could this info be used to recover the "global" coordinate space of the image in the biopsy? Or what does this info refers to?
Thanks in advance for any feedback!