Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide some indication of hinted handoff being accumulated / being sent #1258

Closed
slivne opened this issue Jan 26, 2021 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@slivne
Copy link

slivne commented Jan 26, 2021

We have metrics for hints being written / sent - yet on the overview we need a simple indication of hints being written/sent vs not

(naturally when this happens latency of ongoing requests maybe higher)

@slivne slivne added the enhancement New feature or request label Jan 26, 2021
@amnonh
Copy link
Collaborator

amnonh commented Jan 26, 2021

We have it in the detailed dashbaord, not sure it shuld be part of the overview dashboard

@slivne
Copy link
Author

slivne commented Jan 26, 2021 via email

@amnonh
Copy link
Collaborator

amnonh commented Jan 26, 2021

relates to #1227

@amnonh
Copy link
Collaborator

amnonh commented Feb 4, 2021

We have two options here:

  1. show a text (like the text we show in the nodes table) which is relevent if it happens right now
  2. use annotation, that have the benefit of showing history and show it on a graph, annotations can be turn on or off by defatult

@slivne ping

@amnonh amnonh added this to the monitoring 3.7 milestone Feb 4, 2021
@amnonh
Copy link
Collaborator

amnonh commented Feb 7, 2021

@slivne I'm assigning it to you just for the decision, I think annotations are better becasue of the context and history.

@amnonh
Copy link
Collaborator

amnonh commented Feb 17, 2021

Closed by #1281

@amnonh amnonh closed this as completed Feb 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants