Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

scylla_manager_repair_progress has no description (and is in the middle of the screen, looked like load to me) #2009

Closed
mykaul opened this issue Jun 19, 2023 · 2 comments · Fixed by #2344
Labels
enhancement New feature or request

Comments

@mykaul
Copy link
Contributor

mykaul commented Jun 19, 2023

v4.4.0 - in the middle of the overview there's, next to the manager status, percentage. It's usually 0% (not surprising). While it may initially look like the load, it's the mgmt's repair status. But there's no description, so it's a bit obscure to understand that.

the panel JSON is:

{
  "datasource": {
    "uid": "P1809F7CD0C75ACF3",
    "type": "prometheus"
  },
  "class": "vertical_lcd",
  "fieldConfig": {
    "defaults": {
      "mappings": [],
      "thresholds": {
        "mode": "absolute",
        "steps": [
          {
            "color": "green",
            "value": null
          }
        ]
      },
      "decimals": 0,
      "unit": "percent",
      "min": 0,
      "max": 100
    },
    "overrides": []
  },
  "gridPos": {
    "h": 4,
    "w": 1,
    "x": 8,
    "y": 2
  },
  "id": 10,
  "options": {
    "reduceOptions": {
      "values": false,
      "calcs": [
        "last"
      ],
      "fields": ""
    },
    "orientation": "vertical",
    "displayMode": "lcd",
    "valueMode": "color",
    "showUnfilled": true,
    "minVizWidth": 0,
    "minVizHeight": 10
  },
  "pluginVersion": "9.5.2",
  "targets": [
    {
      "expr": "(sum(avg(scylla_manager_repair_progress{cluster=~\"$cluster|$^\"}) by (task) * sum(scylla_manager_task_active_count{type=\"repair\",cluster=~\"$cluster|$^\"}) by (task)) or on () vector(0)) + (sum(avg(scylla_manager_backup_percent_progress{cluster=~\"$cluster|$^\"}) by (task) * sum(scylla_manager_task_active_count{type=\"backup\",cluster=~\"$cluster|$^\"}) by (task)) or on () vector(0))",
      "instant": true,
      "interval": "",
      "legendFormat": "",
      "refId": "A",
      "datasource": {
        "uid": "P1809F7CD0C75ACF3",
        "type": "prometheus"
      }
    }
  ],
  "timeFrom": null,
  "timeShift": null,
  "type": "bargauge"
}
@mykaul mykaul added the bug Something isn't working right label Jun 19, 2023
@amnonh
Copy link
Collaborator

amnonh commented Jun 21, 2023

when it's non zero, the mananger should change from online to the actuall app being used

@amnonh amnonh added enhancement New feature or request and removed bug Something isn't working right labels Oct 26, 2023
@amnonh
Copy link
Collaborator

amnonh commented Oct 26, 2023

I'm making it an enhancement so with future functionality we can make it clearer

amnonh added a commit to amnonh/scylla-grafana-monitoring that referenced this issue Jul 4, 2024
This patch makes it clearer that the manager progress indication relates
to the manager by combining the manager text indicator with the progress
indicator in the same panel.

Fixes scylladb#2009
@amnonh amnonh added this to the Monitoring 4.8 milestone Jul 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants