Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

scylla plugin executables are making the repo 153mb #2246

Closed
fruch opened this issue Mar 26, 2024 · 4 comments · Fixed by #2411
Closed

scylla plugin executables are making the repo 153mb #2246

fruch opened this issue Mar 26, 2024 · 4 comments · Fixed by #2411
Assignees
@amnonh
Labels
breaking-changes This change is not backward compatible bug Something isn't working right
Milestone
Monitoring 4.9

Comments

@fruch
Copy link
Contributor

fruch commented Mar 26, 2024

seems like those were added in:
fb1c9d1

and at least for SCT how it's operate today, it pulling all of that from github, and slowing it down quite considerably

do we really need the executables in the repo ? can't we use github artifacts for that ?
@fruch fruch added the bug Something isn't working right label Mar 26, 2024
@mykaul
Copy link
Contributor

mykaul commented Mar 26, 2024

Probably need to switch them to use git-lfs

fruch added a commit to fruch/scylla-cluster-tests that referenced this issue Mar 31, 2024
@fruch
fix(docker): multiple fixes to docker_backend_local.yaml
678c129 
* fix case back to older monitoring stack, cause of scylladb/scylla-monitoring#2246
* rate limit also prepare phase
* disable argus reporting for this case
@fruch fruch mentioned this issue Mar 31, 2024
Merged
3 tasks
fruch added a commit to fruch/scylla-cluster-tests that referenced this issue Mar 31, 2024
@fruch
fix(docker): multiple fixes to docker_backend_local.yaml
2cca62b 
* fix case back to older monitoring stack, cause of scylladb/scylla-monitoring#2246
* rate limit also prepare phase
* disable argus reporting for this case
fruch added a commit to scylladb/scylla-cluster-tests that referenced this issue Apr 2, 2024
@fruch
fix(docker): multiple fixes to docker_backend_local.yaml
716e294 
* fix case back to older monitoring stack, cause of scylladb/scylla-monitoring#2246
* rate limit also prepare phase
* disable argus reporting for this case
@fruch
Copy link
Contributor Author

fruch commented Sep 8, 2024

@amnonh

is there anything we can do with this one ? in any case we still need to clone this repo, it's slows it down considerably

@amnonh
Copy link
Collaborator

amnonh commented Sep 8, 2024

The artifacts need to be in the repository, or the plugin will not work. Technically, I can remove some of them and add comments to the documentation.
I'll start with that. It's a breaking change so it will be part of the master and the next release

@fruch
Copy link
Contributor Author

fruch commented Sep 8, 2024

The artifacts need to be in the repository, or the plugin will not work. Technically, I can remove some of them and add comments to the documentation. I'll start with that. It's a breaking change so it will be part of the master and the next release

Thanks, it would help speeding up some of the test cases (and local development in SCT)

@amnonh amnonh mentioned this issue Oct 8, 2024
Merged
@amnonh amnonh added this to the Monitoring 4.9 milestone Oct 8, 2024
@amnonh amnonh added the breaking-changes This change is not backward compatible label Oct 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@amnonh amnonh

Labels
breaking-changes This change is not backward compatible bug Something isn't working right
Projects
None yet
Milestone
Monitoring 4.9
Development

Successfully merging a pull request may close this issue.

Update plugin 0 4 0 amnonh/scylla-grafana-monitoring
3 participants
@fruch @amnonh @mykaul