-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introspect operator image to prevent skew with the sidecar #1425
Conversation
9ffadd4
to
7c2160e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good change, thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame we have to pull the Pod's status for that, I though it could be possible with OCI compliant runtimes but it looks like the only way to do it now is hacky and may be unreliable due to pause containers (opencontainers/runtime-spec#1105 and containerd/containerd#8185).
Left two comments.
/assign @tnozicka |
7c2160e
to
24b2d61
Compare
/lgtm |
Description of your changes:
This PR let's the scylla operator image be introspected from pod status when run in the cluster.
Which issue is resolved by this Pull Request:
Resolves #1424