Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop unused examples and scripts #2273

Merged

Conversation

rzetelskik
Copy link
Member

Description of your changes: To minimise the number of manifests and scripts we have to keep unified (such as in #2049) and up to date, we should drop the unused scripts and examples. This PR drops the deployment scripts and examples earlier used in our docs, which became obsolete with the recent changes.

Which issue is resolved by this Pull Request:
Resolves #

/kind cleanup
/priority important-longterm

@scylla-operator-bot scylla-operator-bot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 16, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 16, 2024
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
(lgtm)

/assign @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@rzetelskik
Copy link
Member Author

/test images
/retest

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel aa98152 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

related to #2274 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 0fd61b5 into scylladb:master Dec 17, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants