Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update time docs to reflect new chrono feature flag name #1123

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

willshiao
Copy link
Contributor

@willshiao willshiao commented Nov 13, 2024

Changes chrono -> chrono-04 to reflect the new name for the feature flag. This was confusing when I was trying to find the feature flag.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Changes `chrono` -> `chrono-04` to reflect the new name for the feature flag.
Copy link

github-actions bot commented Nov 13, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: af69a1d

@wprzytula wprzytula requested a review from muzarski November 13, 2024 07:42
@wprzytula
Copy link
Collaborator

I believe we need to check other features in this aspect, because there are more that has been recently suffixed with a major version number and the docs might have fallen behind.

@muzarski
Copy link
Contributor

I believe we need to check other features in this aspect, because there are more that has been recently suffixed with a major version number and the docs might have fallen behind.

True. I've found suspects in following files:

  • date.md
  • time.md
  • timestamp.md

We should rename chrono -> chrono-04 and time -> time-03 in these files. @willshiao could you adjust all of these?

I see that bigdecimal-04, num-bigint-03 and num-bigint-04 features are documented correctly.

@wprzytula wprzytula added the area/documentation Improvements or additions to documentation label Nov 13, 2024
Also fix some previously unchanged occurences of the `chrono` feature flag.
@willshiao
Copy link
Contributor Author

willshiao commented Nov 14, 2024

Just made the requested name changes. I searched for occurrences of `time` or `chrono` in Markdown files so I should've gotten all of them but lmk if I missed any

Copy link
Contributor

@muzarski muzarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@muzarski muzarski requested a review from Lorak-mmk November 15, 2024 12:41
Copy link
Collaborator

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started the CI and will merge after it passes.

@Lorak-mmk Lorak-mmk merged commit dbcb168 into scylladb:main Nov 20, 2024
12 checks passed
wprzytula pushed a commit to wprzytula/scylla-rust-driver that referenced this pull request Dec 11, 2024
Update time docs to reflect new chrono feature flag name

(cherry picked from commit dbcb168)
@wprzytula wprzytula mentioned this pull request Dec 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants