Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cql_types_test: Don't rely on MIN/MAX values of NaiveDate #919

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Lorak-mmk
Copy link
Collaborator

This PR changes test_naive_date so that it doesn't rely on current values of NaiveDate::MIN. This is necessary because CI broke after update of chrono changed those values.

Fixes: #917

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested a review from piodul January 24, 2024 15:00
@piodul piodul merged commit 2d8cd7b into scylladb:main Jan 24, 2024
8 checks passed
@Lorak-mmk Lorak-mmk self-assigned this Jan 25, 2024
@Lorak-mmk Lorak-mmk mentioned this pull request Feb 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on test_naive_date
2 participants