Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing load_demo by pointing to new bucket #287

Merged
merged 3 commits into from
May 5, 2023
Merged

Fixing load_demo by pointing to new bucket #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a187d7
Fixing load_demo by pointing to new bucket
amontanez24 May 4, 2023
ec67fba
adding issue to release notes
amontanez24 May 4, 2023
39b01fa
fixing tests and release notes
amontanez24 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## v0.7.2 - 2023-05-04

This release adds support for Pandas 2.0 and PyTorch 2.0!
This release adds support for Pandas 2.0 and PyTorch 2.0! It also fixes a bug in the `load_demo` function.

### Bugs Fixed

* load_demo raises urllib.error.HTTPError: HTTP Error 403: Forbidden - Issue [#284](https://github.com/sdv-dev/CTGAN/issues/284) by @amontanez24

### Maintenance

Expand Down
2 changes: 1 addition & 1 deletion ctgan/demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pandas as pd

DEMO_URL = 'http://ctgan-data.s3.amazonaws.com/census.csv.gz'
DEMO_URL = 'http://ctgan-demo.s3.amazonaws.com/census.csv.gz'


def load_demo():
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/synthesizer/test_ctgan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ def test_continuous():
# - uniform (assert p-value > 0.05)
# - gaussian (assert p-value > 0.05)
# - inversely correlated (assert correlation < 0)
pass


def test_categorical():
Expand All @@ -248,6 +249,7 @@ def test_categorical():
# - uniform (assert p-value > 0.05)
# - very skewed / biased? (assert p-value > 0.05)
# - inversely correlated (assert correlation < 0)
pass


def test_categorical_log_frequency():
Expand All @@ -257,22 +259,26 @@ def test_categorical_log_frequency():
# - uniform (assert p-value > 0.05)
# - very skewed / biased? (assert p-value > 0.05)
# - inversely correlated (assert correlation < 0)
pass


def test_mixed():
"""Test training the CTGAN synthesizer on a small mixed-type dataset."""
# assert the distribution of the samples is close to the distribution of the data
# using a kstest for continuous + a cstest for categorical.
pass


def test_conditional():
"""Test training the CTGAN synthesizer and sampling conditioned on a categorical."""
# verify that conditioning increases the likelihood of getting a sample with the specified
# categorical value
pass


def test_batch_size_pack_size():
"""Test that if batch size is not a multiple of pack size, it raises a sane error."""
pass


def test_ctgan_save_and_load(tmpdir):
Expand Down