Refactoring #1
Merged
Refactoring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
added a commit
that referenced
this pull request
May 26, 2021
* sdgym-gretel: adding gretel synthesizer * pr comments and changes discussed in OH * getting rid of error messages * moving static method out * Cureate dependencies to avoid conflicts Co-authored-by: Carles Sala <carles@pythiac.com>
csala
added a commit
that referenced
this pull request
May 27, 2021
amontanez24
added a commit
that referenced
this pull request
Jun 3, 2021
* sdgym-gretel: adding gretel synthesizer * pr comments and changes discussed in OH * getting rid of error messages * moving static method out * Cureate dependencies to avoid conflicts Co-authored-by: Carles Sala <carles@pythiac.com>
csala
added a commit
that referenced
this pull request
Jun 7, 2021
* sdgym-gretel (#1) * sdgym-gretel: adding gretel synthesizer * pr comments and changes discussed in OH * getting rid of error messages * moving static method out * Cureate dependencies to avoid conflicts Co-authored-by: Carles Sala <carles@pythiac.com> * Minor improvements to the summary functions * Add summary function and command * adding cli commands and finishing up script * adding tests * refactoring and changing method signature * Adding s3 parameters and functionality * pr comments and removing unused code Co-authored-by: Carles Sala <carles@pythiac.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.