Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(loaders): Add test for load_configuration #164

Merged
merged 1 commit into from
Oct 9, 2023
Merged

test(loaders): Add test for load_configuration #164

merged 1 commit into from
Oct 9, 2023

Conversation

madhavmk
Copy link
Collaborator

@madhavmk madhavmk commented Oct 9, 2023

  • Improve test coverage for loaders.py load_configuration()
  • Add .idea files to gitignore

@madhavmk
Issue seafloor-geodesy#123 : Add test for load_configuration
1cf4a56 
* Improve test coverage for loaders.py load_configuration()
* Add .idea files to gitignore
@madhavmk madhavmk self-assigned this Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0854d95) 38.87% compared to head (1cf4a56) 41.95%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   38.87%   41.95%   +3.08%     
==========================================
  Files          15       15              
  Lines         746      746              
==========================================
+ Hits          290      313      +23     
+ Misses        456      433      -23

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan lsetiawan self-requested a review October 9, 2023 16:17
@lsetiawan lsetiawan changed the title Issue #123 : Add test for load_configuration test(loaders): Add test for load_configuration Oct 9, 2023
@lsetiawan lsetiawan linked an issue Oct 9, 2023 that may be closed by this pull request
Add test for load_configuration #123
Closed
@lsetiawan
Copy link
Member

lsetiawan commented Oct 9, 2023 •
edited
Loading

This is great @madhavmk! Thank you. Could you also ensure that you're catching the ValidationError

Update: This is already handled in a separate test.

lsetiawan
lsetiawan approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhavmk madhavmk merged commit 584972b into seafloor-geodesy:main Oct 9, 2023
@madhavmk madhavmk deleted the issue_123 branch May 14, 2024 01:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lsetiawan lsetiawan lsetiawan approved these changes

Assignees

@madhavmk madhavmk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for load_configuration
2 participants
@madhavmk @lsetiawan