Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Review :dialect/:quoted docs -- ensure it's clear that :quoted nil is valid #463

Closed
seancorfield opened this issue Feb 21, 2023 · 3 comments
Closed

Review :dialect/:quoted docs -- ensure it's clear that :quoted nil is valid #463

seancorfield opened this issue Feb 21, 2023 · 3 comments
Assignees
@seancorfield
Labels
documentation I need to write something up!

Comments

@seancorfield
Copy link
Owner

The docs may imply that :quoted has to be either true or false when you use :dialect. Make sure it's clear that you can also use :quoted nil to have the dialect with the default quoting strategy.
@seancorfield seancorfield added the documentation I need to write something up! label Feb 21, 2023
@seancorfield seancorfield self-assigned this Feb 21, 2023
@nharsch
Copy link

nharsch commented Feb 21, 2023

@seancorfield working on a PR

nharsch pushed a commit to nharsch/honeysql that referenced this issue Mar 3, 2023
refs seancorfield#463 - document dialect + quoted = nil behavior
4b5e4e8
@nharsch
Copy link

nharsch commented Mar 3, 2023 •
edited
Loading

@seancorfield #475

seancorfield added a commit that referenced this issue Mar 3, 2023
@seancorfield
Merge pull request #475 from nharsch/issue-463
3e23ad5 
refs #463 - document dialect + quoted = nil behavior
@seancorfield
Copy link
Owner Author

Thank you!

seancorfield added a commit that referenced this issue Mar 3, 2023
@seancorfield
note #463 / #475 in changelog
f0ccaae
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@seancorfield seancorfield

Labels
documentation I need to write something up!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seancorfield @nharsch