Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement a basic SQLite dialect. #452

Closed
wants to merge 1 commit into from

Conversation

lnchan
Copy link

@lnchan lnchan commented Jan 7, 2023

This dialect allows for supporting the same REPLACE INTO syntax supported by MySQL, without changing the quote format or other behaviors. This allows the dialect to also be extended in the future with SQLite-specific syntax.

Alternatively, the REPLACE INTO syntax could be made to be used without any dialects.

This dialect allows for supporting the same `REPLACE INTO` syntax
supported by MySQL, without changing the quote format or other
behaviors.  This allows the dialect to also be extended in the future
with SQLite-specific syntax.
@seancorfield
Copy link
Owner

Thanks! I'll take a look at this when I get back from vacation in a week or so.

@seancorfield
Copy link
Owner

Given that REPLACE INTO doesn't seem to conflict with any other dialect, I think your suggestion to just implement it in the "ANSI" core makes sense (since it also removes a weirdness caused by trying to mix MySQL and non-MySQL code, given that the MySQL dialect is side-effecting right now).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants