Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow single kw in :order-by and other clauses #470

Merged

Conversation

p-himik
Copy link
Contributor

@p-himik p-himik commented Feb 26, 2023

Fixes #467

Also fixes not being able to use helpers to merge into stuff like {:select :id} - e.g. (hh/select {:select :id} :x) would throw.

I would also update README so it mentions the "plain" syntax earlier and uses it wherever possible.

@seancorfield seancorfield merged commit fc33976 into seancorfield:develop Feb 27, 2023
@seancorfield
Copy link
Owner

I'll think about the documentation aspect. This was a new "feature" in v2.x that fell out of an implementation detail for the most part. I'll create an issue for doc updates.

@p-himik p-himik deleted the 467-allow-scalar-order-by-et-al branch February 27, 2023 22:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent requirements for :order-by and :group-by
2 participants