Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(wasm): support request timeout #1760

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Feb 24, 2023

Thanks for PR #1755, making wasm timeout support is super easy now.

fixes #1135 supersede #1274

Cargo.toml Outdated Show resolved Hide resolved
@flisky
Copy link
Contributor Author

flisky commented May 17, 2023

I've replace gloo-timers with wasm-bindgen functions.

(For the potential question: why not use web_sys::Window::set_timout_*? Because Window doesn't work in nodejs & webworker. However, I can switch into predefined functions if Window is only target.)

@aorticweb
Copy link

is there a plan to merge this please?

@Aursen
Copy link

Aursen commented Jul 25, 2024

Hi any news about this one? To know if it's planned to add it or not?

@chris13524
Copy link

I don't usually bump threads, but curious what is the holdup on this one? 😄 Seems like an easy win

@seanmonstar
Copy link
Owner

So sorry this slipped, yes this seems much simpler. Happy to add it!

It seems like there's a test failure in WASM, though. Related?

@flisky
Copy link
Contributor Author

flisky commented Jan 15, 2025

Yes. I've shorten the timeout to reproduce timeout error in firefox.

It turns out that error message keywords didn't match, @seanmonstar

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seanmonstar seanmonstar merged commit 0f360b8 into seanmonstar:master Jan 16, 2025
36 checks passed
@Nuhvi
Copy link
Contributor

Nuhvi commented Feb 6, 2025

@seanmonstar will there be a release with this any time soon? Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestBuilder doesn't have a timeout in wasm module
7 participants