Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove Sync restriction on stream bassed into warp::sse::reply #683

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Remove Sync restriction on stream bassed into warp::sse::reply #683

merged 1 commit into from
Aug 6, 2020

Conversation

wngr
Copy link
Contributor

@wngr wngr commented Aug 6, 2020

As the Sync requirement on Body::wrap_stream was removed in hyperium/hyper#2187, it can now also be removed on the stream passed to warp::sse::reply.

@jxs
Copy link
Collaborator

jxs commented Aug 6, 2020

thanks! lgtm, I have also relaxed the Sync need on #663

@jxs jxs merged commit 3626a0b into seanmonstar:master Aug 6, 2020
@wngr wngr deleted the ow/sse-sync-body branch August 6, 2020 11:12
@parasyte parasyte mentioned this pull request Jan 4, 2021
Closed
jxs pushed a commit to jxs/warp that referenced this pull request Jun 27, 2021
@wngr @jxs
remove Sync restriction on SSE stream (seanmonstar#683)
6848ee4
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wngr @jxs