Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: compile the package before publishing #144

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

raing3
Copy link
Contributor

@raing3 raing3 commented Jul 17, 2024

I think this PR duplicates #141. Little hard to tell as the compiled file may have been built from a different commit.

Feels more reliable to compile before publish to remember to recompile.

Hoping to use a feature that doesn't appear to be in the compiled sources. Would appreciate getting a new version published with the changes.

Thanks!

Copy link
Owner

@seantomburke seantomburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seantomburke seantomburke merged commit 7fa779b into seantomburke:master Sep 23, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants