pass highlighting to SolrPage Paginator pages
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance for a test? |
|
Speaking of tests, I'm going to try to get them running on Travis. |
|
sure, I'll also add a page size test to the |
|
@tingletech I think any test would be great ; there are already tests that demonstrate this PR doesn't break anything. So any sort of test of the expected new behavior would be great. |
|
It would also be cool to test that this even still works from django, last time I tried was django 1.3. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark Redar's change to sorlpy that we needed for the portal project demo
Without this, hit highlighting didn't work for paginated pages